Skip to content

Replace all hard coded env variables needed to make sample sites dynamic accross UID2/EUID - #53

Merged
eiman-eltigani-ttd merged 39 commits into
mainfrom
eee-UID2-6076-replace-hard-coded-env-variables
Oct 29, 2025
Merged

eiman-eltigani-ttd merged 39 commits into
mainfrom
eee-UID2-6076-replace-hard-coded-env-variables

Conversation

@eiman-eltigani-ttd

@eiman-eltigani-ttd eiman-eltigani-ttd commented Oct 28, 2025 •

Copy link
Copy Markdown
Contributor

Summary of changes:

  • Added new variables to dynamically update html content and read me (PRODUCT_NAME, DOCS_BASE_URL) and additonal variables needed for Google Secure Integrations
  • Generalize variable names to use UID_ preface and ensure consistentcy
  • Expand ReadMes to include instructions for both UID2 and EUID2, and create seperate .env.sample files to ensure users default to right values
  • Ensure sites working correctly for UID2 only

@eiman-eltigani-ttd
eiman-eltigani-ttd marked this pull request as ready for review October 28, 2025 17:11
Comment thread web-integrations/google-secure-signals/client-server/views/index.html Outdated
Comment thread web-integrations/google-secure-signals/client-server/views/index.html Outdated

// UI/Display configuration
const productName = process.env.PRODUCT_NAME || 'UID2';
const docsBaseUrl = process.env.DOCS_BASE_URL || 'https://unifiedid.com/docs';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure we want to default these variables to UID2 if they do not exist

Comment thread web-integrations/google-secure-signals/client-side/html/scripts/scripts.js Outdated
Comment thread web-integrations/google-secure-signals/client-side/html/scripts/scripts.js Outdated
Comment thread web-integrations/google-secure-signals/client-server/views/index.html Outdated
Comment thread web-integrations/google-secure-signals/client-server/views/login.html Outdated
Comment thread web-integrations/google-secure-signals/client-server/README.md Outdated
Comment thread web-integrations/google-secure-signals/client-server/README.md Outdated
Comment thread web-integrations/google-secure-signals/client-server/server.js
Comment thread web-integrations/google-secure-signals/client-side/html/scripts/scripts.js Outdated
Comment thread web-integrations/google-secure-signals/client-side/README.md Outdated
Comment thread web-integrations/google-secure-signals/client-side/README.md Outdated
Comment thread web-integrations/google-secure-signals/client-side/README.md
Comment thread web-integrations/google-secure-signals/react-client-side/src/SecureSignalsApp.tsx Outdated
Comment thread web-integrations/google-secure-signals/server-side/views/header.html Outdated
Comment thread web-integrations/google-secure-signals/server-side/README.md Outdated
Comment thread .env.sample.euid
Comment thread .env.sample.euid Outdated
Comment thread web-integrations/google-secure-signals/server-side/README.md Outdated
Comment thread web-integrations/javascript-sdk/client-server/README.md Outdated
Comment thread .env.sample.euid
Comment thread .env.sample.uid2 Outdated
Comment thread web-integrations/google-secure-signals/client-server/README.md Outdated
Comment thread web-integrations/google-secure-signals/client-side/README.md Outdated
Comment thread web-integrations/google-secure-signals/server-side/README.md Outdated
Comment thread web-integrations/javascript-sdk/client-server/README.md Outdated
Comment thread web-integrations/javascript-sdk/client-side/README.md Outdated
@eiman-eltigani-ttd
eiman-eltigani-ttd merged commit cb1bf4b into main Oct 29, 2025
2 checks passed
@eiman-eltigani-ttd
eiman-eltigani-ttd deleted the eee-UID2-6076-replace-hard-coded-env-variables branch October 29, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants